Rename PoliciesController#show to PoliciesController#index
What does this MR do?
Noticed in !67900 (comment 647982245) - The PoliciesController
list view has a few things that don't make sense for a list view. It's likely that it ended up like this because we used to use this page to show policy configuration options and then we changed it to show a list view plus an "Edit policy management project" button.
- The action should be named
#index
- The path should be pluralized
This MR fixes those things and also makes the controller error handling redirect to the list view when there is a problem with the parameters on the #edit
action.
This feature is still in development and is behind a feature flag.
Epic for this feature: &5362 (closed)
Screenshots or Screencasts (strongly suggested)
Parameter errors on the edit page now redirect to the list view.
Screen_Recording_2021-08-11_at_12.22.10_PM
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Brian Williams