Skip to content

Add new and edit pages for policies

Alexander Turinske requested to merge 321884-add-new-and-edit-page into master

What does this MR do?

Add new and edit pages for Policies sidebar, which is replacing the index/new/edit pages of the Threat Monitoring Policies tab

  • link them to the policy editor page
  • account for policy type needing to always be a parameter for the edit page
  • condense policy type constants
  • update tests
  • update locale

How to setup and validate locally (strongly suggested)

  1. Follow the Protect Onboarding task to be able to create network policies in kubernetes/cilium
  2. Follow the scan execution creation snippet to create some scan execution policies
  3. Turn on the :security_policies_orchestration_configuration feature flag
  4. Navigate to Security & Compliance => Policies
  5. Select New Policy or select a policy, wait for the drawer to open, and click Edit Policy

Screenshots or Screencasts (strongly suggested)

Title Threat Monitoring Page (the page we are replicating/moving) Policies Page (the page we are creating to replace)
List/Drawer (Container Network Policy) threat_container_network_sidebar policy_container_network_sidebar
List/Drawer (Container Cilium Policy) threat_container_cilium_sidebar policy_container_cilium_sidebar
List/Drawer (Scan Execution Policy) threat_scan_execution_sidebar policy_scan_execution_sidebar
New page threat_new_page image
Edit page (Container Cilium Policy) threat_contanier_cilium_edit_page (there is more work to do on this one, but this MR provides the foundation) policy_edit_page

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #321884 (closed)

Edited by Alexander Turinske

Merge request reports