Skip to content
Snippets Groups Projects

Removed dependency on $ from the highlighter

Merged Denys Mishunov requested to merge dmishunov/highlighter-without-jquery into master

What does this MR do?

This is a unification of the syntax highlighter (used in GFM markup in particular) that allows the syntax highlighter to be used without jQuery. In particular, we now can:

  • pass jQuery nodes (original behavior)
  • a NodeList as a result of vanilla document.querySelectorAll()
  • a Node as a result of vanilla document.querySelector()

Also, this allows us to have one more module jquery-free.

Screenshots or Screencasts (strongly suggested)

No visual changes:

Before (master) After (this branch)
Screenshot_2021-08-09_at_16.54.10 Screenshot_2021-08-09_at_16.53.02

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Denys Mishunov

Merge request reports

Merged results pipeline #350310932 passed

Pipeline: CNG-mirror

#350328419

    Merged results pipeline passed for c2ccad02

    Test coverage 71.82% (14.09%) from 3 jobs

    Merged by Vitaly SlobodinVitaly Slobodin 3 years ago (Aug 11, 2021 9:12am UTC)

    Loading

    Pipeline #351428627 passed

    Pipeline passed for 334f5665 on master

    Test coverage 57.73% (14.09%) from 3 jobs
    6 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply
    Loading