Add the retry button to failed migrations
What does this MR do?
Allows admins to retry background migrations in the web UI
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
- Create a failed migration.
Example:
Gitlab::Database::BackgroundMigration::BatchedMigration.create!(
job_class_name: 'MyJobClass',
table_name: 'projects',
column_name: 'id',
interval: 300,
min_value: 5,
max_value: 1000,
batch_class_name: 'MyBatchClass',
batch_size: 100,
sub_batch_size: 10,
job_arguments: %w[],
status: 'failed',
)
-
Go to
http://127.0.0.1:3000/admin/background_migrations?tab=failed
-
Click on the button
retry
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Relates to #326760 (closed)
Merge request reports
Activity
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains deprecated components. Please consider using Pajamas components instead. Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- has-tooltip
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
) (UTC+10, 8 hours ahead of@dfrazao-gitlab
)Dmitry Gruzd ( @dgruzd
) (UTC+3, 1 hour ahead of@dfrazao-gitlab
)database David Sincheol Kim ( @dskim_gitlab
) (UTC+9.5, 7.5 hours ahead of@dfrazao-gitlab
)Tiger Watson ( @tigerwnz
) (UTC+10, 8 hours ahead of@dfrazao-gitlab
)frontend Coung Ngo ( @cngo
) (UTC+1, 1 hour behind@dfrazao-gitlab
)Andrew Fontaine ( @afontaine
) (UTC-4, 6 hours behind@dfrazao-gitlab
)test Quality for spec/features/*
Nick Westbury ( @nwestbury
) (UTC+1, 1 hour behind@dfrazao-gitlab
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Userassigned to @dfrazao-gitlab
Allure report
allure-report-publisher
generated test report for 0037970c!review-qa-smoke:
test reportEdited by Ghost UserSetting label groupdatabase based on
@dfrazao-gitlab
's group.added groupdatabase label
added Engineering Allocation label
Setting label(s) Category:Database devopsenablement sectionenablement based on groupdatabase.
added Category:Database devopssystems sectioncore platform labels
added 1 commit
- 08b3d88b - add request test for background migrations controller