Skip to content

Resolve "Add pronunciation to GitLab profile page"

Manoj M J requested to merge 25742-add-pronunciation-to-gitlab-profile-page into master

What does this MR do?

For #25742 (closed)

This change

  • Allows users to set their pronunciation from their profile (/-/profile page).
  • The set pronunciation will then be shown in their public user profile (/:username page).

Screenshots or Screencasts (strongly suggested)

Adding pronunciation in user profile:

Screen_Shot_2021-08-02_at_11.32.53_AM

Pronunciation shown in user profile: Screen

Screen_Shot_2021-08-03_at_11.05.08_AM

Pronunciation shown in user profile: Mobile

Screen_Shot_2021-08-03_at_11.05.51_AM

DB Migrations

Up migration

rake db:migrate
== 20210729061526 AddPronunciationToUserDetails: migrating ====================
-- add_column(:user_details, :pronunciation, :text, {:null=>true})
   -> 0.0411s
== 20210729061526 AddPronunciationToUserDetails: migrated (0.0491s) ===========

== 20210729061556 AddTextLimitToUserDetailsPronunciation: migrating ===========
-- transaction_open?()
   -> 0.0000s
-- current_schema()
   -> 0.0003s
-- execute("ALTER TABLE user_details\nADD CONSTRAINT check_f932ed37db\nCHECK ( char_length(pronunciation) <= 255 )\nNOT VALID;\n")
   -> 0.0058s
-- current_schema()
   -> 0.0002s
-- execute("SET statement_timeout TO 0")
   -> 0.0006s
-- execute("ALTER TABLE user_details VALIDATE CONSTRAINT check_f932ed37db;")
   -> 0.0020s
-- execute("RESET ALL")
   -> 0.0007s
== 20210729061556 AddTextLimitToUserDetailsPronunciation: migrated (0.0189s) ==

Down migration

rake db:migrate:down VERSION=20210729061556
== 20210729061556 AddTextLimitToUserDetailsPronunciation: reverting ===========
-- execute("ALTER TABLE user_details\nDROP CONSTRAINT IF EXISTS check_f932ed37db\n")
   -> 0.0014s
== 20210729061556 AddTextLimitToUserDetailsPronunciation: reverted (0.0083s) ==
rake db:migrate:down VERSION=20210729061526
== 20210729061526 AddPronunciationToUserDetails: reverting ====================
-- remove_column(:user_details, :pronunciation)
   -> 0.0012s
== 20210729061526 AddPronunciationToUserDetails: reverted (0.0078s) ===========

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #25742 (closed)

Edited by Manoj M J

Merge request reports