Skip to content

Refactor `Environment#stop_actions` for the CI Database split

What does this MR do?

Environment#stop_actions is going to be broken after we move the ci_* tables to a separate database, because the deployments/environments tables and the ci_builds table do NOT co-exist in the same database, meaning they can't be cross-joined with JOIN clause.

This MR refactors the batch stop operation with bulk_perform_async in Sidekiq. This approach has the following advantages:

On the other hand, this approach has the following disadvantages:

  • This technically embraces N+1 queries into Sidekiq jobs, therefore the total query count will increase. (However, technically N+1 can't be completely resolved because stop_action.play (Ci::PlayBuildService) is a too complicated to be preloaded/batch-execution)

Related #336435 (closed) #336427 (closed)

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #336435 (closed)

Edited by Dylan Griffith

Merge request reports