Refactor `Environment#stop_actions` for the CI Database split
What does this MR do?
Environment#stop_actions
is going to be broken after we move the ci_*
tables to a separate database, because the deployments
/environments
tables and the ci_builds
table do NOT co-exist in the same database, meaning they can't be cross-joined with JOIN
clause.
This MR refactors the batch stop operation with bulk_perform_async
in Sidekiq. This approach has the following advantages:
- Since each stop action is encapsulated in a asynchronous job, the process is horizontally scalable. This is a similar approach in the pipeline schedule cron worker.
- The code is more readable and maintainable. We use
Environment#stop_with_action!
as the SSOT method to stop an environment, so we don't need to maintain two kinds of stop logic separately (individual vs batch). - It's easy to extend the stop logic. We have bunch of upcoming issues for the environments automatic cleanup.
On the other hand, this approach has the following disadvantages:
- This technically embraces N+1 queries into Sidekiq jobs, therefore the total query count will increase. (However, technically N+1 can't be completely resolved because
stop_action.play
(Ci::PlayBuildService
) is a too complicated to be preloaded/batch-execution)
Related #336435 (closed) #336427 (closed)
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #336435 (closed)
Edited by Dylan Griffith