Resolve "Address the Primary Key Overflow risk for the taggings table - Step 2: Finalize background migrations and swap columns"

What does this MR do?

This MR finalize the conversion to bigint for taggings table.

At a high level, the operation takes the following steps:

1. Ensure the migration of id to bigint is completed.
2. Ensure the migration of taggable_id to bigint is completed.
3. Copy index
4. Swap columns, drop existing PK, define new PK, swap sequences

Cleanup (removing the old int columns and the triggers) will be done in later MR.

Migration Output

Up

== 20210806131706 FinalizeTagginsBigintConversion: migrating ==================
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", :id_convert_to_bigint, {:unique=>true, :name=>"index_taggings_on_id_convert_to_bigint", :algorithm=>:concurrently})
   -> 0.0041s
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", [:taggable_id_convert_to_bigint, :taggable_type], {:name=>"i_taggings_on_taggable_id_convert_to_bigint_and_taggable_type", :algorithm=>:concurrently})
   -> 0.0036s
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", [:taggable_id_convert_to_bigint, :taggable_type, :context], {:name=>"i_taggings_on_taggable_bigint_and_taggable_type_and_context", :algorithm=>:concurrently})
   -> 0.0030s
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", [:tag_id, :taggable_id_convert_to_bigint, :taggable_type, :context, :tagger_id, :tagger_type], {:unique=>true, :name=>"taggings_idx_tmp", :algorithm=>:concurrently})
   -> 0.0027s
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", :id_convert_to_bigint, {:where=>"taggable_type = 'Project'", :name=>"tmp_index_taggings_on_id_bigint_where_taggable_type_project", :algorithm=>:concurrently})
   -> 0.0027s
-- execute("SET statement_timeout TO 0")
   -> 0.0005s
-- add_index("taggings", :id_convert_to_bigint, {:where=>"taggable_type = 'Project'", :name=>"tmp_index_taggings_on_id_bigint_where_taggable_type_project", :algorithm=>:concurrently})
   -> 0.0029s
-- execute("RESET statement_timeout")
   -> 0.0006s
-- execute("LOCK TABLE taggings IN ACCESS EXCLUSIVE MODE")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name(:taggable_id)
   -> 0.0000s
-- quote_column_name("taggable_id_tmp")
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"taggable_id\" TO \"taggable_id_tmp\"")
   -> 0.0007s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name(:taggable_id_convert_to_bigint)
   -> 0.0000s
-- quote_column_name(:taggable_id)
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"taggable_id_convert_to_bigint\" TO \"taggable_id\"")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name("taggable_id_tmp")
   -> 0.0000s
-- quote_column_name(:taggable_id_convert_to_bigint)
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"taggable_id_tmp\" TO \"taggable_id_convert_to_bigint\"")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name(:id)
   -> 0.0000s
-- quote_column_name("id_tmp")
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"id\" TO \"id_tmp\"")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name(:id_convert_to_bigint)
   -> 0.0000s
-- quote_column_name(:id)
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"id_convert_to_bigint\" TO \"id\"")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name("id_tmp")
   -> 0.0000s
-- quote_column_name(:id_convert_to_bigint)
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"id_tmp\" TO \"id_convert_to_bigint\"")
   -> 0.0006s
-- quote_table_name("trigger_aebe8b822ad3")
   -> 0.0000s
-- execute("ALTER FUNCTION \"trigger_aebe8b822ad3\" RESET ALL")
   -> 0.0007s
-- execute("ALTER SEQUENCE taggings_id_seq OWNED BY taggings.id")
   -> 0.0015s
-- change_column_default("taggings", :id, #)
   -> 0.0029s
-- change_column_default("taggings", :id_convert_to_bigint, 0)
   -> 0.0017s
-- execute("ALTER TABLE taggings DROP CONSTRAINT taggings_pkey CASCADE")
   -> 0.0012s
-- rename_index("taggings", "index_taggings_on_id_convert_to_bigint", "taggings_pkey")
   -> 0.0007s
-- execute("ALTER TABLE taggings ADD CONSTRAINT taggings_pkey PRIMARY KEY USING INDEX taggings_pkey")
   -> 0.0014s
-- execute("DROP INDEX index_taggings_on_taggable_id_and_taggable_type")
   -> 0.0006s
-- rename_index("taggings", "i_taggings_on_taggable_id_convert_to_bigint_and_taggable_type", "index_taggings_on_taggable_id_and_taggable_type")
   -> 0.0006s
-- execute("DROP INDEX index_taggings_on_taggable_id_and_taggable_type_and_context")
   -> 0.0006s
-- rename_index("taggings", "i_taggings_on_taggable_bigint_and_taggable_type_and_context", "index_taggings_on_taggable_id_and_taggable_type_and_context")
   -> 0.0006s
-- execute("DROP INDEX taggings_idx")
   -> 0.0006s
-- rename_index("taggings", "taggings_idx_tmp", "taggings_idx")
   -> 0.0006s
-- execute("DROP INDEX tmp_index_taggings_on_id_where_taggable_type_project")
   -> 0.0006s
-- rename_index("taggings", "tmp_index_taggings_on_id_bigint_where_taggable_type_project", "tmp_index_taggings_on_id_where_taggable_type_project")
   -> 0.0006s
== 20210806131706 FinalizeTagginsBigintConversion: migrated (0.0940s) =========

Down

== 20210806131706 FinalizeTagginsBigintConversion: reverting ==================
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", :id_convert_to_bigint, {:unique=>true, :name=>"index_taggings_on_id_convert_to_bigint", :algorithm=>:concurrently})
   -> 0.0034s
-- execute("SET statement_timeout TO 0")
   -> 0.0005s
-- add_index("taggings", :id_convert_to_bigint, {:unique=>true, :name=>"index_taggings_on_id_convert_to_bigint", :algorithm=>:concurrently})
   -> 0.0029s
-- execute("RESET statement_timeout")
   -> 0.0005s
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", [:taggable_id_convert_to_bigint, :taggable_type], {:name=>"i_taggings_on_taggable_id_convert_to_bigint_and_taggable_type", :algorithm=>:concurrently})
   -> 0.0024s
-- add_index("taggings", [:taggable_id_convert_to_bigint, :taggable_type], {:name=>"i_taggings_on_taggable_id_convert_to_bigint_and_taggable_type", :algorithm=>:concurrently})
   -> 0.0019s
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", [:taggable_id_convert_to_bigint, :taggable_type, :context], {:name=>"i_taggings_on_taggable_bigint_and_taggable_type_and_context", :algorithm=>:concurrently})
   -> 0.0024s
-- add_index("taggings", [:taggable_id_convert_to_bigint, :taggable_type, :context], {:name=>"i_taggings_on_taggable_bigint_and_taggable_type_and_context", :algorithm=>:concurrently})
   -> 0.0018s
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", [:tag_id, :taggable_id_convert_to_bigint, :taggable_type, :context, :tagger_id, :tagger_type], {:unique=>true, :name=>"taggings_idx_tmp", :algorithm=>:concurrently})
   -> 0.0029s
-- add_index("taggings", [:tag_id, :taggable_id_convert_to_bigint, :taggable_type, :context, :tagger_id, :tagger_type], {:unique=>true, :name=>"taggings_idx_tmp", :algorithm=>:concurrently})
   -> 0.0019s
-- transaction_open?()
   -> 0.0000s
-- index_exists?("taggings", :id_convert_to_bigint, {:where=>"taggable_type = 'Project'", :name=>"tmp_index_taggings_on_id_bigint_where_taggable_type_project", :algorithm=>:concurrently})
   -> 0.0030s
-- add_index("taggings", :id_convert_to_bigint, {:where=>"taggable_type = 'Project'", :name=>"tmp_index_taggings_on_id_bigint_where_taggable_type_project", :algorithm=>:concurrently})
   -> 0.0020s
-- execute("LOCK TABLE taggings IN ACCESS EXCLUSIVE MODE")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name(:taggable_id)
   -> 0.0000s
-- quote_column_name("taggable_id_tmp")
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"taggable_id\" TO \"taggable_id_tmp\"")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name(:taggable_id_convert_to_bigint)
   -> 0.0000s
-- quote_column_name(:taggable_id)
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"taggable_id_convert_to_bigint\" TO \"taggable_id\"")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name("taggable_id_tmp")
   -> 0.0000s
-- quote_column_name(:taggable_id_convert_to_bigint)
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"taggable_id_tmp\" TO \"taggable_id_convert_to_bigint\"")
   -> 0.0005s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name(:id)
   -> 0.0000s
-- quote_column_name("id_tmp")
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"id\" TO \"id_tmp\"")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name(:id_convert_to_bigint)
   -> 0.0000s
-- quote_column_name(:id)
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"id_convert_to_bigint\" TO \"id\"")
   -> 0.0006s
-- quote_table_name("taggings")
   -> 0.0000s
-- quote_column_name("id_tmp")
   -> 0.0000s
-- quote_column_name(:id_convert_to_bigint)
   -> 0.0000s
-- execute("ALTER TABLE \"taggings\" RENAME COLUMN \"id_tmp\" TO \"id_convert_to_bigint\"")
   -> 0.0006s
-- quote_table_name("trigger_aebe8b822ad3")
   -> 0.0000s
-- execute("ALTER FUNCTION \"trigger_aebe8b822ad3\" RESET ALL")
   -> 0.0006s
-- execute("ALTER SEQUENCE taggings_id_seq OWNED BY taggings.id")
   -> 0.0007s
-- change_column_default("taggings", :id, #)
   -> 0.0021s
-- change_column_default("taggings", :id_convert_to_bigint, 0)
   -> 0.0016s
-- execute("ALTER TABLE taggings DROP CONSTRAINT taggings_pkey CASCADE")
   -> 0.0008s
-- rename_index("taggings", "index_taggings_on_id_convert_to_bigint", "taggings_pkey")
   -> 0.0006s
-- execute("ALTER TABLE taggings ADD CONSTRAINT taggings_pkey PRIMARY KEY USING INDEX taggings_pkey")
   -> 0.0009s
-- execute("DROP INDEX index_taggings_on_taggable_id_and_taggable_type")
   -> 0.0006s
-- rename_index("taggings", "i_taggings_on_taggable_id_convert_to_bigint_and_taggable_type", "index_taggings_on_taggable_id_and_taggable_type")
   -> 0.0006s
-- execute("DROP INDEX index_taggings_on_taggable_id_and_taggable_type_and_context")
   -> 0.0006s
-- rename_index("taggings", "i_taggings_on_taggable_bigint_and_taggable_type_and_context", "index_taggings_on_taggable_id_and_taggable_type_and_context")
   -> 0.0006s
-- execute("DROP INDEX taggings_idx")
   -> 0.0006s
-- rename_index("taggings", "taggings_idx_tmp", "taggings_idx")
   -> 0.0006s
-- execute("DROP INDEX tmp_index_taggings_on_id_where_taggable_type_project")
   -> 0.0006s
-- rename_index("taggings", "tmp_index_taggings_on_id_bigint_where_taggable_type_project", "tmp_index_taggings_on_id_where_taggable_type_project")
   -> 0.0005s
== 20210806131706 FinalizeTagginsBigintConversion: reverted (0.0780s) =========

Database migrations

Timings

From DB Lab:

1. CREATE INDEX CONCURRENTLY "i_taggings_on_taggable_bigint_and_taggable_type_and_context" ON "taggings" ("taggable_id_convert_to_bigint", "taggable_type", "context");

   Duration: 94.860 min - https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/5353/commands/18774

2. CREATE INDEX CONCURRENTLY "i_taggings_on_taggable_id_convert_to_bigint_and_taggable_type" ON "taggings" ("taggable_id_convert_to_bigint", "taggable_type");

   Duration: 58.935 min - https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/5353/commands/18767

3. CREATE UNIQUE INDEX CONCURRENTLY "taggings_idx_tmp2" ON "taggings" ("tag_id", "taggable_id_convert_to_bigint", "taggable_type", "context", "tagger_id", "tagger_type");

   Duration: 109.485 min - https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/5353/commands/18803

4. CREATE UNIQUE INDEX CONCURRENTLY "index_taggings_on_id_convert_to_bigint" ON "taggings" ("id_convert_to_bigint");

   Duration: 56.231 min - https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/5353/commands/18843

5. CREATE INDEX CONCURRENTLY "tmp_index_taggings_on_id_convert_to_bigint_where_taggable_type_project" ON "taggings" ("id_convert_to_bigint") WHERE taggable_type = 'Project'

   Duration: 30.368 min - https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/6267/commands/21182

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

• I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
• I have added/updated documentation, or it's not needed. (Is documentation required?)
• I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
• I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
• I have self-reviewed this MR per code review guidelines.
• This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
• I have followed the style guides.
• This change is backwards compatible across updates, or this does not apply.

Availability and Testing

• I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
• I have tested this MR in all supported browsers, or it's not needed.
• I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Related to #334823 (closed)