Remove not_null constraint on project_fingerprint for `security_findings`

What does this MR do?

We are in the process of deprecating the usage of the project_fingerprint attribute of the findings. As there is a null constraint associated to project_fingerprint, we are facing difficulties to remove the use of project_fingerprint from code without removing this constraint. We already introduced uuid which will be used instead of project_fingerprint. This is one step further to deprecate project_fingerprint.

Database Review

Up

== 20210713223941 RemoveNullConstraintFromSecurityFindings: migrating =========
-- change_column_null(:security_findings, :project_fingerprint, true)
   -> 0.0050s
== 20210713223941 RemoveNullConstraintFromSecurityFindings: migrated (0.0050s) 

Down

== 20210713223941 RemoveNullConstraintFromSecurityFindings: reverting =========
== 20210713223941 RemoveNullConstraintFromSecurityFindings: reverted (0.0000s) 

Does this MR meet the acceptance criteria?

Conformity

• I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
• I have added/updated documentation, or it's not needed. (Is documentation required?)
• I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
• I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
• I have self-reviewed this MR per code review guidelines.
• This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
• I have followed the style guides.
• This change is backwards compatible across updates, or this does not apply.

Related to #335700 (closed)

changed milestone to %14.1

added Category:Vulnerability Management backend database devopssecure groupthreat insights sectionsec workflowin dev labels

assigned to @subashis

added databasereview pending label

	3 Warnings
	9515ded6: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	This MR has a Changelog commit with the EE: true trailer, but there are database changes which requires the Changelog commit to not have the EE: true trailer. Consider removing the EE: true trailer from your commits.
	Please add a merge request type to this merge request.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Brett Walker (@digitalmoksha) (UTC-5, 1 hour ahead of @subashis)	Alex Kalderimis (@alexkalderimis) (UTC+1, 7 hours ahead of @subashis)
database	Dylan Griffith (@DylanGriffith) (UTC+10, 16 hours ahead of @subashis)	Tiger Watson (@tigerwnz) (UTC+10, 16 hours ahead of @subashis)
~migration	No reviewer available	No maintainer available

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in commit bdf81152

added 379 commits

• b19677cd...96fe611a - 378 commits from branch master
• bdf81152 - Remove not_null constraint on project_fingerprint

Compare with previous version

mentioned in commit 7123bafc

added 1 commit

• 7123bafc - Remove not_null constraint on project_fingerprint

Compare with previous version

mentioned in commit 0197b6d9

added 1 commit

• 0197b6d9 - Remove not_null constraint on project_fingerprint

Compare with previous version

marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed

marked the checklist item I have added/updated documentation, or it's not needed. (Is documentation required?) as completed

marked the checklist item I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) as completed

marked the checklist item I have self-reviewed this MR per code review guidelines. as completed

marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed

marked the checklist item I have followed the style guides. as completed

marked this merge request as ready

@minac Can you pls do the initial review for backend and database changes in this MR?