Rails5 fix no implicit conversion of Symbol into Integer
What does this MR do?
perform_async
with ActionController::Parameters
as argument was converted to a string. to_h
fixes this for Rails5, but to_h
can also not be used for Rails 4, as this would mean it wouldn't be a ActiveSupport::HashWithIndifferentAccess
anymore, but this is also required by the ExportCsvWorker
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
rails5 upgrade
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conforms to the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
EE specific content should be in the top level /ee
folder -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #6930 (closed)
Edited by Coung Ngo