Skip to content

Rails5 fix no implicit conversion of Symbol into Integer

Jasper Maes requested to merge jlemaes/gitlab-ee:rails5-fix-6930 into master

What does this MR do?

perform_async with ActionController::Parameters as argument was converted to a string. to_h fixes this for Rails5, but to_h can also not be used for Rails 4, as this would mean it wouldn't be a ActiveSupport::HashWithIndifferentAccess anymore, but this is also required by the ExportCsvWorker

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #6930 (closed)

Edited by Coung Ngo

Merge request reports