Handle schedule linked to escalation rule removal - simple case
What does this MR do?
When oncall-schedule that escalation rule is linked to is deleted, the rule in the escalation policy is deleted as well. So we can have a situation where the policy has no rules. For the first pass we'll simply add a warning message to the delete schedule modal + when policy has no rules - display a red warning instead of the rules.
A more sophisticated approach is still discussed.
This fix is essential for the feature flag removal
To check:
Enable escalation_policies_mvc
feature flag
The minimal license required is GitLab Premium
Navigate to your project=>Monitor=>Escalation Policies.
Add escalation policy with some schedule
Delete a schedule that was linked to the policy
Observe that policy without rules has a warning
Screenshots or Screencasts (strongly suggested)
Schedule confirmation message
Empty rules warning
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #334739