Ensure pages visibility levels are correct
What does this MR do?
- Change the value of "Public" when setting the visibility level of a **private project with access control enabled on GitLab pages.
- Previously this was set to
30
, when it should be20
. Since30 > 20
, this didn't cause authorization issues, but it did cause the audit log to save "Public" statuses as "Unknown".
Screenshots or Screencasts (strongly suggested)
Before (bottom 2 rows), After (top 2 rows)
How to test
-
Set up GitLab pages on GDK.
- Make sure access control is enabled. (Merge the following with the new changes to
gdk.yml
.)
- Make sure access control is enabled. (Merge the following with the new changes to
gitlab_pages:
access_control: true
- Create a private project.
- Change the visilbilty status from Public to Internal, and back again.
- Check the result in the project audit log.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #271638
Edited by Max Woolf