Skip to content

Ensure pages visibility levels are correct

Max Woolf requested to merge 271638-pages-audit-events into master

What does this MR do?

  • Change the value of "Public" when setting the visibility level of a **private project with access control enabled on GitLab pages.
  • Previously this was set to 30, when it should be 20. Since 30 > 20, this didn't cause authorization issues, but it did cause the audit log to save "Public" statuses as "Unknown".

Screenshots or Screencasts (strongly suggested)

Before (bottom 2 rows), After (top 2 rows)

Screenshot_2021-07-08_at_09.28.54

How to test

gitlab_pages:
  access_control: true
  • Create a private project.
  • Change the visilbilty status from Public to Internal, and back again.
  • Check the result in the project audit log.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #271638

Edited by Max Woolf

Merge request reports