Add user_cap column to namespace_settings
What does this MR do?
Relates to #332590 (closed). Epic, for more context, is here.
This MR adds a user_cap
integer column to the namespace_settings
table.
As written in this epic, this is a continuation of something that was done for self-managed, as we're bringing that user cap feature to Saas. This is the equivalent MR to this one here done for self-managed (ie. the MR where the user cap column is created for self-managed instances)
Migration Up/Down
etienne@dell ~/src/gdk/gitlab(332590-add-user-cap-column-to-namespace-settings ✗) rails db:migrate:up VERSION=20210705132928
== 20210705132928 AddNewUserSignupsCapToNamespaceSettings: migrating ==========
-- add_column(:namespace_settings, :new_user_signups_cap, :integer, {:null=>true})
-> 0.0008s
== 20210705132928 AddNewUserSignupsCapToNamespaceSettings: migrated (0.0042s) =
etienne@dell ~/src/gdk/gitlab(332590-add-user-cap-column-to-namespace-settings ✗) rails db:migrate:down VERSION=20210705132928
== 20210705132928 AddNewUserSignupsCapToNamespaceSettings: reverting ==========
-- remove_column(:namespace_settings, :new_user_signups_cap)
-> 0.0007s
== 20210705132928 AddNewUserSignupsCapToNamespaceSettings: reverted (0.0044s) =
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #332590 (closed)
Edited by Etienne Baqué