Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,877
    • Issues 35,877
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,261
    • Merge Requests 1,261
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !45643

Merged
Opened Oct 20, 2020 by Vitaly Slobodin@vitallium🔮Maintainer6 of 13 tasks completed6/13 tasks

Add new configuration option for setting the new user signups cap

  • Overview 50
  • Commits 25
  • Pipelines 14
  • Changes 15

What does this MR do?

Add a new configuration option for setting the new user signups cap. This MR just adds visual control for this setting. Further implementation follows.

Closes #211390 (closed).

Screenshots

image

Database

Migration up

== 20201019113009 AddNewUserSignupsCapToApplicationSettings: migrating ========
-- add_column(:application_settings, :new_user_signups_cap, :integer)
   -> 0.0055s
== 20201019113009 AddNewUserSignupsCapToApplicationSettings: migrated (0.0056s)

Migration down

== 20201019113009 AddNewUserSignupsCapToApplicationSettings: reverting ========
-- remove_column(:application_settings, :new_user_signups_cap, :integer)
   -> 0.0066s
== 20201019113009 AddNewUserSignupsCapToApplicationSettings: reverted (0.0114s)

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Oct 21, 2020 by Vitaly Slobodin
Assignee
Assign to
Reviewer
Request review from
13.6
Milestone
13.6 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!45643
Source branch: vs-admin-new-user-signups