Skip to content

Improve the 'review' job and make it manual

Rémy Coutable requested to merge make-review-app-jobs-manual into master

What does this MR do?

  1. In order to investigate https://gitlab.com/gitlab-org/gitlab-ee/issues/6884 properly, this change the review job to be manual.
  2. This also merges the review-app-image job into the review job because there's no real reason to put review in the post-test stage. => I abandoned this idea for now since the charts Docker image doesn't seem to have a recent Ruby installed (this can be improved in a later iteration).
  3. Lastly, this extract the deployment shell functions to a separate file to improve maintenance, and it also makes the file CE-ready by default the Rails images to the CE ones, and using the EE images in the case of an EE pipeline.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Because Review Apps aren't working as expected right now:

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Rémy Coutable

Merge request reports