[EE] Move Danger to test stage
EE MR for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20654.
What does this MR do?
This moves the Danger review to the test
stage. The benefit is that it gives a few minutes for the developer to create the MR, having more chance that Danger can successfully find the MR and post a comment on it.
This also improves a bit danger/changelog/Dangerfile
and danger/specs/Dangerfile
(see specific commits).
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
- Conform to the code review guidelines
-
Has been reviewed by a Backend maintainer
-
-
EE specific content should be in the top level /ee
folder -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conform to the database guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan - [-] End-to-end tests pass (
package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/49185.
Edited by 🤖 GitLab Bot 🤖