Run batched migrations on self-managed instances
What does this MR do?
This enables batched background migrations for all instances. We need them to be completed before we can swap columns to bigint.
Without this cron job running, upgrading to a version that has the bigint swap migrations would fail.
See #288005 (comment 614744621) / gitlab-org/charts/gitlab#2785 (closed) / #334996 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
assigned to @engwan
changed milestone to %14.1
added backend devopssystems groupdatabase labels
1 Warning Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Amparo Luna ( @a_luna
) (UTC-5, 13 hours behind@engwan
)Jan Provaznik ( @jprovaznik
) (UTC+2, 6 hours behind@engwan
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in issue #288005 (closed)
@engwan Thanks, looks good. Let's find a maintainer to merge it.
@rspeicher can you review please?
requested review from @rspeicher
- Resolved by Heinrich Lee Yu
We need to backport this to %14.0. Every major upgrade has to go through 14.0 and in the best case folks are using the latest version that includes this patch. They'll have their migrations run automatically and - best case - don't notice this problem when they do another upgrade later.
@engwan Do you agree about backporting it?
mentioned in issue gitlab-org/charts/gitlab#2785 (closed)
@engwan LGTM so I'll approve, but I'm unsure about the resolution for the remaining discussion above.
added Engineering Allocation label
Setting label(s) Category:Database sectionenablement based on groupdatabase.
added Category:Database sectioncore platform labels
mentioned in merge request !64999 (merged)
mentioned in issue #334996 (closed)
- Resolved by Yannis Roussos
Adding Pick into 14.0 for the reasons discussed in #288005 (comment 615521675)