Skip to content

Make coverage approval rule frontend-configurable

What does this MR do?

For #331001 (closed)

This MR adds a configurable MR approval rule (Coverage-Check) to project settings.

The backend for this rule was already implemented in !63079 (merged), which works with any rule named Coverage-Check. This MR just makes it easier to discover and configure a rule with the required name.

This MR also adds documentation about what the rule does and how to configure it.

Handy test project: https://gitlab.com/iamricecake/test-merge-approvals

Screenshots

screenshot explanation
Screen_Shot_2021-07-09_at_14.47.54 unconfigured placeholder Coverage-Check rule in project settings (Settings -> General -> MR Approvals)
coverage_check_approval_rule configuring a Coverage-Check rule
Screen_Shot_2021-07-09_at_14.48.26 configured Coverage-Check rule
Screen_Shot_2021-07-09_at_14.19.22 once the rule is defined, an MR that causes coverage to go down will not be mergeable until it is approved by the user/group
Screen_Shot_2021-07-09_at_14.21.24 and an MR that doesn't affect coverage will not require the same approval

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Miranda Fluharty

Merge request reports