Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,811
    • Issues 43,811
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,433
    • Merge requests 1,433
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #331001
Closed
Open
Created May 14, 2021 by Scott Hampton@shampton💡Maintainer

Display code coverage approval rule in project settings

Problem to solve

We are creating a custom approval rule similar to License Check and Vulnerability Check approval rules (see #15765 (closed)). As part of this, we need to implement the frontend project setting so that the user can enable this approval rule.

Proposal

We will need to coordinate with the backend to create a new approval rule setting. We can follow the pattern set out in the security approval rules which is laid out in:

  • https://gitlab.com/gitlab-org/gitlab/-/blob/421d10b7e7f79bd687d08555031ebaf352405e21/ee/app/assets/javascripts/approvals/components/project_settings/project_rules.vue
  • https://gitlab.com/gitlab-org/gitlab/-/blob/421d10b7e7f79bd687d08555031ebaf352405e21/ee/app/assets/javascripts/approvals/components/security_configuration/unconfigured_security_rules.vue

Issue for creating the rule: #331001 (closed)

Here is a previous MR implementing this for security: !38992 (merged)

Edited Jun 14, 2021 by James Heimbuck
Assignee
Assign to
Time tracking