Remove the 'Regulated' tab from compliance frameworks
What does this MR do?
This MR removes the tab structure from compliance frameworks as we no longer need the regulated
tab (we've pivoted away from using it and it was always disabled).
It also updates the non-empty layout a bit to move the Add framework
button to the bottom now we don't have tabs and remove the top-border of the container.
Screenshots (strongly suggested)
View | Before | After |
---|---|---|
Empty | ||
List |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
- Go to
[HOST]/groups/[GROUP]/-/edit#js-compliance-frameworks-settings
- Remove any frameworks if you have some created and check the empty state doesn't have double borders or two add buttons
- Add a few frameworks and check the add button is shown and it doesn't have double borders
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #326032 (closed)
Edited by Robert Hunt