Skip to content
Snippets Groups Projects

Reintroduce recursive_approach_for_all_projects default-enabled

What does this MR do?

Reintroduced the recursive_approach_for_all_projects feature flag which was removed in !55043 (merged). It also default-enables the FF so as not to disrupt GitLab.com or self-managed instances that are not experiencing problems.

However, this gives customers that are experiencing performance problems after upgrading a temporary path to unblock. Then we can address the performance problems iteratively.

Related to #334251 (closed).

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Drew Blessing

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Etienne Baqué

      It also default-enables the FF so as not to disrupt GitLab.com or self-managed instances that are not experiencing problems.

      However, this gives customers that are experiencing performance problems after upgrading a temporary path to unblock. Then we can address the performance problems iteratively.

      Are there any GitLab.com performance issues?

      @dblessing, I'm wondering what the drawbacks are to making this flag default disabled? Since that would require less manual interventions by users. Are we seeing a performance enhancement in some cases but not others?

      Edited by Allison Browne
  • Allison Browne approved this merge request

    approved this merge request

  • Allison Browne removed review request for @allison.browne

    removed review request for @allison.browne

  • Drew Blessing added 1 commit

    added 1 commit

    • 6ad6ca68 - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • mentioned in issue #334817 (closed)

  • Drew Blessing added 1 commit

    added 1 commit

    • c269b211 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Drew Blessing requested review from @ebaque

    requested review from @ebaque

  • Etienne Baqué approved this merge request

    approved this merge request

  • Etienne Baqué resolved all threads

    resolved all threads

  • Etienne Baqué enabled an automatic merge when the pipeline for 142d4630 succeeds

    enabled an automatic merge when the pipeline for 142d4630 succeeds

  • Etienne Baqué mentioned in commit 18d2c779

    mentioned in commit 18d2c779

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #331429 (closed)

  • mentioned in issue #335064 (closed)

  • Alex Pooley mentioned in merge request !65296 (merged)

    mentioned in merge request !65296 (merged)

  • mentioned in issue #334004 (closed)

  • @dblessing This merge request could not automatically be picked into 13-12-stable-ee for 13.12.7-ee and will need manual intervention.

    Create a new merge request targeting the 13-12-stable-ee-patch-7 branch in order to have this MR included in !65366 (merged).

    Please follow the Process for Developers.

  • mentioned in merge request !65366 (merged)

  • Imre Farkas mentioned in merge request !65430 (merged)

    mentioned in merge request !65430 (merged)

  • Imre Farkas mentioned in commit bedeefdc

    mentioned in commit bedeefdc

  • Mayra Cabrera mentioned in commit e3ac0395

    mentioned in commit e3ac0395

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading