Skip to content

Cloud Licensing: Adjust Subs Details height

Angelo Gulina requested to merge ag-327882-details-cards-height into master

What does this MR do?

Related to gitlab-org/gitlab#327882 this MR makes sure the height of the Subscription Details and User Info align on the bottom side by having the same height.

A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

Local Testing

  1. Make sure not to have any license

  2. Make sure you have set the following environment vars (usually in your terminal) and restart gdk

    • GITLAB_LICENSE_MODE is set to test
    • CUSTOMER_PORTAL_URL is set to https://customers.stg.gitlab.com
  3. Use Rails console to run ApplicationSetting.current.update(cloud_license_enabled: true)

  4. Visit Admin > Subscription

  5. Use the activation code 9y9bv7k16uu7f4Y8vGGt177P

Screenshots (strongly suggested)

desktop

Before After
before after

mobile

Screenshot_2021-06-22_at_08.25.49 Screenshot_2021-06-22_at_08.26.00 Screenshot_2021-06-22_at_08.26.10

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports