Store fetched group labels in vuex
What does this MR do?
As a minor improvement for create/edit value stream form, we should fetch a default set of group labels and keep them in the vuex store, currently each time the labels_selector component is loaded in the form, a request is made for all the labels.
This was not an issue with the previous form as the form didnt allow the addition of multiple stages at a time. Now that we allow the addition of more stages when editing / creating a value stream, this leads to unnecessary API requests.
This was initially brought up in #198592 (closed)
NOTE: as an improvement we could probably search the vuex store when searching for a label, instead of hitting the endpoint. But i'll leave this out for now as i'd like to first explore removing the custom labels_selector entirely.
Screenshots (strongly suggested)
No visual changes
Labels requests on load
| Before - labels are requested | After - labels are preloaded, so no request |
|---|---|
| Screen_Recording_2021-07-28_at_1.41.54_pm | Screen_Recording_2021-07-28_at_1.24.11_pm |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #198592 (closed)