Skip to content

Rails5 fix expected: ({...}) got: (<ActionController::Parameters {...})

Jasper Maes requested to merge jlemaes/gitlab-ee:rails5-fix-6606 into master

What does this MR do?

Similar fix as gitlab-ce!20007.

ActionController::Parameters.new is now used instead of a hash, and boolean parameters are strings(they already where in Rails 4 when performing real requests from a browser), see: https://github.com/rails/rails/issues/26075#issuecomment-238527844

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Closes #6606 (closed)

Edited by Rémy Coutable

Merge request reports