Skip to content

Trim input from subscription activation from

Angelo Gulina requested to merge ag-trim-input into master

What does this MR do?

This MRs fixes a bug where, when activating a subscription, the form would not trim the value. Note that validation for the input is planned here gitlab-org/gitlab#323071

The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

To test the changes locally

  1. Delete any previous license you might have

  2. Make sure you have set the following vars

    • GITLAB_LICENSE_MODE is set to test
    • CUSTOMER_PORTAL_URL is set to https://customers.stg.gitlab.com
  3. Use Rails console to run ApplicationSetting.current.update(cloud_license_enabled: true)

  4. Navigate to admin/cloud_license

  5. Use the following activation code: sVYsJcSFw4kvHBpB3mgK4469 (with blank spaces)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports