Enable epic_boards feature flag by default
What does this MR do?
Enables :epic_boards
feature flag by default, aiming for 14.0 release.
History of Epic boards feature development
Previous iterations | MR link |
---|---|
Index page | !53100 (merged) |
Empty lists | !54169 (merged) |
Epics in lists | !54528 (merged) |
Multiple epic boards switcher | !54399 (merged) |
Create epic board | !54642 (merged) |
Display epic reference in card | !55028 (merged) |
Add label list | !55011 (merged) |
Collapse list and polish | !55456 (merged) |
MVC1 bug fixes | !55709 (merged) |
Drag & Drop epic | !56170 (merged) |
Fix mentions of issues to epics | !56292 (merged) |
Update board scope | !55815 (merged) |
Delete epic board | !57186 (merged) |
Edit epic labels | !57973 (merged) |
Edit epic title | !58727 (merged) |
Edit epic confidentiality | !58968 (merged) |
Edit epic subscribed state | !59214 (merged) |
Edit epic start and due dates | !59446 (merged) |
Delete epic board list | !60559 (merged) |
Display epic's participants in sidebar | !60885 (merged) |
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #290039 (closed)
Merge request reports
Activity
changed milestone to %14.0
assigned to @fguibert
added workflowin dev label and removed workflowready for development label
1 Warning ⚠ 0531b906: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Drew Blessing ( @dblessing
) (UTC-5, 15 hours behind@fguibert
)Stan Hu ( @stanhu
) (UTC-7, 17 hours behind@fguibert
)frontend Zack Cuddy ( @zcuddy
) (UTC-5, 15 hours behind@fguibert
)Nathan Friend ( @nfriend
) (UTC-4, 14 hours behind@fguibert
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost Usermentioned in commit 4ab46dc3
- Resolved by Nathan Friend
FYI @cdybenko @donaldcook @msedlakjakubowski (as this is a dependency for docs update)
@jprovaznik I noticed we turn off the feature flag for some backend tests. Is that something we want to update when we default it on or when we remove it? (edit: looking at the pipeline I think we'd need those changes here). Feel free to push to this branch if it needs updating when enabling it.
I set the status of this MR as Draft since we're waiting for some dependencies to be able to release this feature but I created this in advance so we're ready to release.
Edited by Florie Guibert
mentioned in merge request !62434 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!79899 (merged)
mentioned in commit 0531b906
added 2139 commits
-
d8268839...e5c04dd7 - 2137 commits from branch
master
- 0531b906 - Epic Boards
- 7aa551c2 - Add default_enabled param
-
d8268839...e5c04dd7 - 2137 commits from branch
Allure report
allure-report-publisher
generated test report for 9983d6e6!review-qa-smoke:
📝 test reportEdited by Ghost User@dblessing @zcuddy Could you please review?
Changes look good to me.
Non-blocking Question: Should the commit message with the Changelog trailer be more descriptive in terms of enabling the feature flag by default? If we haven't previously mentioned Epic Boards in the changelog maybe it's sufficient as the first introduction of the feature.
@fguibert Looks good to me! Approved
✅ I'll give you a chance to respond to @dblessing's non-blocking suggestion above. Feel free to ping me when this is ready to merge.
@dblessing It's the first mention of it in the changelog, I thought it was enough.
@nfriend Assigning back to you to merge.
Edited by Florie Guibert@fguibert MWPS set
✅ @fguibert
👍 I agree since it's the first mention of the feature.
requested review from @dblessing and @zcuddy
added workflowin review label and removed workflowin dev label