Enable by default Allow force push option to Protected branches [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Contributes to #323431 (closed)
- Delete feature flag and related code
- Update documentation
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %14.0
added backend feature flag groupsource code typefeature labels
assigned to @vyaklushin
- A deleted user
added documentation frontend labels
1 Warning This merge request contains deprecated components. Please consider using Pajamas components instead. 2 Messages This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Documentation review
The following files require a review from a technical writer:
doc/user/project/protected_branches.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- has-tooltip
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
) (UTC+10, 8 hours ahead of@vyaklushin
)Markus Koller ( @toupeira
) (UTC+2, same timezone as@vyaklushin
)frontend Justin Boyson ( @jboyson
) (UTC-5, 7 hours behind@vyaklushin
)Savas Vedova ( @svedova
) (UTC+3, 1 hour ahead of@vyaklushin
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 37 commits
-
2cfa1a45...0c176714 - 36 commits from branch
master
- 18ecdf3c - Enable by default Allow force push option to Protected branches
-
2cfa1a45...0c176714 - 36 commits from branch
Setting label(s) Category:Source Code Management devopscreate sectiondev based on groupsource code.
added Category:Source Code Management devopscreate sectiondev labels
- Resolved by Miguel Rincon
Hi @pedropombeiro and @justin_ho!
Can you please review backend and frontend changes respectively?
requested review from @pedropombeiro and @justin_ho
Hi @aqualls!
Can you please review changes to the documentation?requested review from @aqualls
marked the checklist item I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) as completed
- Resolved by Miguel Rincon
requested review from @mrincon and removed review request for @justin_ho
requested review from @dbalexandre and removed review request for @pedropombeiro