Remove include_lfs_blobs_in_archive feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
This feature flag has been enabled by the default since GitLab 13.5, so it's time to remove it.
Part of #268409 (closed)
Merge request reports
Activity
assigned to @stanhu
changed milestone to %14.0
added feature flag groupsource code + 1 deleted label
requested review from @aqualls
Hi @aqualls, please review this documentation Merge Request.
added documentation twtriaged labels
- A deleted user
added backend label
2 Messages This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Documentation review
The following files require a review from a technical writer:
doc/topics/git/lfs/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Rubén Dávila ( @rdavila
) (UTC-5, 2 hours ahead of@stanhu
)James Lopez ( @jameslopez
) (UTC+2, 9 hours ahead of@stanhu
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @seanarnold
added 7 commits
-
0595fe9f...e49d7bf4 - 6 commits from branch
master
- 4467f13b - Remove include_lfs_blobs_in_archive feature flag
-
0595fe9f...e49d7bf4 - 6 commits from branch
- Resolved by Etienne Baqué
added 82 commits
-
4467f13b...c265fbf2 - 81 commits from branch
master
- 8a46af1c - Remove include_lfs_blobs_in_archive feature flag
-
4467f13b...c265fbf2 - 81 commits from branch
added Technical Writing docsimprovement tw-weight3 twdoing labels and removed twtriaged label
- Resolved by Stan Hu
- Resolved by Etienne Baqué
@stanhu I've added one phrasing suggestion. It wasn't part of your original MR, but I couldn't pretend I didn't see it when I was reading through your changes.
You removed the right lines. I know the pipeline's red for non-docs reasons, but I'm approving from a docs perspective and unassigning myself.
added devopscreate twfinished labels and removed twdoing label
removed review request for @aqualls
added 1 commit
- 76d4e08e - Improve wording on LFS in archives documentation
added 40 commits
-
76d4e08e...bae27142 - 39 commits from branch
master
- c17834bb - Remove include_lfs_blobs_in_archive feature flag
-
76d4e08e...bae27142 - 39 commits from branch
- Resolved by Etienne Baqué
requested review from @ebaque and removed review request for @seanarnold
Setting label(s) Category:Source Code Management sectiondev based on groupsource code.
added Category:Source Code Management sectiondev labels
enabled an automatic merge when the pipeline for ed612960 succeeds
mentioned in commit 4b88d6a1
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!39 (merged)
added releasedpublished label and removed releasedcandidate label
added typemaintenance label