Replace occurrences of variances for Cloud Licensing
What does this MR do?
Relates to gitlab-org/gitlab#331777
With this MR we update all occurrences (mostly user-facing) of terms that are a variation of Cloud Licensing. We also update the namespace to make it consistent with the name of the main project.
A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.
-
Delete any previous license you might have
-
Use Rails console to run
ApplicationSetting.current.update(cloud_license_enabled: true) -
Visit
Admin > Subscription -
Enter whatever (even literally) as an activation code and see the error appearing
Note that as suggested here we might insert a rule for Rails to avoid this wording. I'm scoping it out at the moment because mainly the UI is based in Vue.
Screenshots (strongly suggested)
 |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team