Fix the Create new cluster feature
What does this MR do?
Fixes a ~bug on the Create new cluster feature for the GCP provider.
The feature broke suddenly because:
- We didn't pin a specific version of GKE
- The google API changed the default version to 1.19
- Google does not allow Basic Auth for 1.19 versions
This MR fixes by pinning the GKE version back at 1.18.
Still will need a better solution before 1.18 is completely removed from availability. &6049 (closed) seems the best candidate.
Relates to: #331582 (closed)
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Merge request reports
Activity
added backend label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Alina Mihaila ( @alinamihaila
) (UTC+3, 1 hour ahead of@Alexand
)Nick Thomas ( @nick.thomas
) (UTC+1, 1 hour behind@Alexand
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added groupconfigure [DEPRECATED] typebug labels
changed milestone to %14.0
added Pick into auto-deploy label
removed Pick into auto-deploy label
Ideally this should be backported to as many previous patch versions as we usually do, since in the moment that the default GKE version became 1.19, all the versions of GitLab before this change will be affected.
That being said, I considered this issue a severity3 , because there's a workaround, which is to manually create the cluster through the GCP UI, then use our Add existing cluster docs.
Today is still the 22, so I'll wait to add the Pick into 13.12 .
Then my question is, should we add to at least 13.11 and 13.10? Do we still release backports for those?
Looking at this condition from https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-2, it seems it would be appropriate to add the
~pick into 13.10/11
labels:The 22nd has passed and the merge request fixes a bug.
Which will include it in the next patch release (if there is one).
WDYT @alexkalderimis?
Resolving this discussion to merge - feel free to add backports later @Alexand
@skarbek could you give your thoughts on whether we should add the
~pick into 13.10/11/12
labels here?This fixes a bug in the Create new cluster. It got broken for all GitLab versions because of unlack of pinned GKE version. Once the upstream API started providing a new version, all GitLab versions broke. So, this is pinning the version to what we need.
The existing workaround is for users to, instead of using this feature to create clusters through GitLab, create the clusters manually through GCP, then follow documented steps on how to Add existing cluster to GitLab.
It's not ideal, but solves their issue for versions before %14.0.
Also, @nagyv-gitlab let us know if you have any thoughts.
Per https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-2 Yes we should add some pick labels. Keep in mind that since 13.12 is now the latest, per maintenance policy and this not being a security related bug, it'll only be carried to the current available version. Therefore, adding only Pick into 13.12
Reference: https://docs.gitlab.com/ee/policy/maintenance.html#backporting-to-older-releases
Having it in 13.12 is fine. Thanks @Alexand !
Thanks, everyone. Pick into 13.12 added.
added severity3 label
- Resolved by Alex Kalderimis
@tigerwnz could you please take the first review?
added 13 commits
-
d3c65b05...7a6e4f24 - 12 commits from branch
master
- 7cda7fdb - Pin the GKE version to 1.18 for cluster creation
-
d3c65b05...7a6e4f24 - 12 commits from branch
Setting label(s) ~"devops::configure" sectionops based on ~"group::configure".
added devopsconfigure [DEPRECATED] sectionops labels
requested review from @alexkalderimis
- Resolved by Alex Kalderimis
marked the checklist item I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) as completed
enabled an automatic merge when the pipeline for 635285c8 succeeds
mentioned in commit 4b489b16
added Pick into 13.12 label
picked the changes into the branch
13-12-stable-ee-patch-1
with commit 0a1f61feAutomatically picked into !62466 (merged), will merge into
13-12-stable-ee
ready for13.12.1-ee
.mentioned in commit 0a1f61fe
removed Pick into 13.12 label
mentioned in merge request !62466 (merged)
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added Pick into 13.12 label
mentioned in commit 44de5542
removed Pick into 13.12 label
mentioned in merge request !62518 (merged)
mentioned in issue gitlab-com/gl-infra/delivery#1795
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!39 (merged)
added releasedpublished label and removed releasedcandidate label
added groupenvironments label and removed groupconfigure [DEPRECATED] label