Skip to content

Update logic for better readability

Angelo Gulina requested to merge ag-cloud-license-footer-buttons into master

What does this MR do?

With this MR I'm following up on a suggestion for making the code more readable and also making the specs more resilient to cases that were treated with some ambiguity.

A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

Screenshots (strongly suggested)

No UI changes.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports