Skip to content

Add a new error modal for billable members

Vijay Hawoldar requested to merge vij-prevent-invited-group-member-removal into master

What does this MR do?

When viewing the seat usage / billable members list, we display members who are indirect members via an invited group.

This can cause confusion for our customers because those members cannot be removed directly due to the nature of their association with the group (i.e. the invited group would need to be removed as a whole).

To address this, two things are going to change:

  1. adds a new badge alongside applicable invited group billable members to identify them as such (separate MR: !61366 (merged))
  2. This MR: Display an appropriate error when trying to remove those members

Refs #325412 (closed)

Screenshots (strongly suggested)

Screenshot_2021-05-12_at_13.08.44

Testing

The simplest way to test this modal would be to:

  1. Modify this method to simply return false
  2. View the seat usage page for any of your local groups, e.g. http://localhost:3000/groups/my-group/-/seat_usage
  3. Attempt to remove any member (removable should now be false so modal should display)

To test it with a real scenario:

  1. Invite a group (Group B) with members into another group (Group A)
  2. View Group A's seat usage page, e.g. http://localhost:3000/groups/group-a/-/seat_usage
  3. Attempt to remove the member from Group B and view the modal

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vijay Hawoldar

Merge request reports