No worries @agulina! We actually made a late change to designs and are now going with a badge instead of a column, see designs here: #325411[badges.png]
@aalakkad the BE MR to support the new badge should be going into review today.
Providing it doesn't change during the review process, the MR will adjust the billable members API endpoint to return a new attribute, membership_type, e.g.
Currently the possible values for membership_type are:
group_member (users belonging directly to the Group or it's subgroups)
project_member (users belonging directly to Projects within the Group or within subgroups)
group_invite (users belonging to Groups invited to collaborate with the Group and subgroups)
project_invite (users belonging to Groups invited to collaborate with Projects within the Group or subgroups)
Worth pointing out that the last entry, project_invite was a new discovery for me - I didn't realise you could invite a group to a project, until then I was under the impression you could only invite groups to groups
Following , if it helps, my guess around what would be required of the frontend is:
check the membership_type attribute returned from the API
render a string in a badge depending on that value
(optional?) disable the "delete" function unless the membership_type value is one of group_member or project_member
I think 3 could be handled in a separate issue though as this one is purely for clarification of a membership, I think?
Apologies if this is not helpful, but I'd been considering it already as I thought perhaps I could take on the frontend work to help alleviate the pressure on the frontend team
@vij@rhardarson@csouthard Very happy to have @vij take on the FE for this issue if everyone is on board. Thank you all for your flexibility and finding creative ways to keep delivering features!
The last MR is back with the maintainer for final review, don't forsee there being any problem with merging (expecting maintainer to come online in the next hour or two).
If all goes well, I'm hoping it'll just be verification that needs to happen whilst I'm OOO
Please provide a quick summary of the current status (one sentence).
The final MR with the new error modal is with the maintainer, I do not expect there to be any further delays to the merge. As I'm OOO next week, ideally someone else could do the verification of the modal on staging/production when it's deployed () which means this issue can then be closed