Update checkbox styles in group settings "Permissions, LFS, 2FA panel
requested to merge 327350-update-checkbox-styles-in-group-settings-general-permissions-lfs-2fa into master
📖 What does this MR do?
Related to #327350 (closed)
In !57878 (merged) I updated some of the checkbox styles to the new GitLab UI checkboxes. But due to an issue with QA E2E specs I wasn't able to update all of them. That issue has since been resolved so this MR updates the remainder of the checkbox styles in the "General" -> "Permissions, LFS, 2FA" settings panel. This improves consistency of styling and helps the checkboxes line up correctly.
💻 Local testing
- Create a group
- Navigate to "Group" -> "Settings" -> "General" -> "Permissions, LFS, 2FA"
📷 Screenshots
| Before | After |
|---|---|
 |
 |
🚦 Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- No screenshots that I could find that need updating
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman