Reduce request duration for GroupsController#merge_requests [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
As seen by this kibana board, a large percentage of the endpoint requests is to get the count for the number of merge requests by state. This is done to render the mr widget.
Following on the work done in !55971 (merged) this MR reduces the duration of requests for groups with a large number of merge requests. This is done by utilizing the Groups::MergeRequestsCountService to cache counts above a threshold (currently > 1000). The number of expensive count requests is reduced to once per expiry interval (currently 24h).
The counters affected are:
- left subnav showing number of open merge requests (the caching strategy hasn't changed, only the underlying fetch logic)
- group merge request widget navigation showing MR counts by state
Please note that the view for the MR widget only triggers the caching call when no fetching params are present (as defined by MergeRequestFinder).
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325681 (closed)