Skip to content

Cache merge requests count in group sidebar [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

Related to #299542 (closed)

Similarly to the work done for issues, and for performance reasons, in this MR we implement caching the merge request count in the sidebar at a group level. This value will be cached with the following conditions:

  • The total count will be cached only if it's over the threshold value (currently 1000).
  • The cache will expire after 24 hours.
  • To reflect that any count over the threshold value is "imprecise" they will be truncated by thousands. For example, 2350 -> 2.3k, 14300 -> 14.3k, 112560 -> 112.6k.

This change is behind the FF cached_sidebar_merge_requests_count, enabled by default.

Screenshots (strongly suggested)

Screen_Shot_2021-03-23_at_15.42.11

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Eugenia Grieff

Merge request reports