Skip to content
Snippets Groups Projects

Migrate admin runner list from HAML to Vue [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Merged Miguel Rincon requested to merge 329658-migrate-admin-runner-list-from-haml-to-vue into master

What does this MR do?

This MR defines a new feature flag: runner_list_view_vue_ui that renders the runner administrator using Vue and GraphQL, part of #329658 (closed).

:point_up: This MR is large: It defines the new feature flag and ports the main features of the Runners list, as much of these features are relatively simple and they follow the layout almost exactly I think it's possible to port in fewer steps. Also, not all features have been ported, please see #329658 (closed) for a full list.

Screen_Shot_2021-05-17_at_1.17.04_PM

:warning: Depends on !61174 (merged) and requires runner_graphql_query to be enabled.

Screenshots (strongly suggested)

runner_list_view_vue_ui OFF runner_list_view_vue_ui ON
Screen_Shot_2021-05-17_at_12.25.37_PM Screen_Shot_2021-05-17_at_1.15.32_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #329658 (closed)

Edited by Miguel Rincon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading