Enable snippets to use reference filter cache
What does this MR do?
With the refactored Banzai reference cache, we now enable the SnippetReferenceFilter
to take advantage of it.
Related to #327630 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.12
1 Warning ⚠ Please add a merge request type to this merge request. 2 Messages 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 61076 "Enable snippets to use reference filter cache"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 61076 "Enable snippets to use reference filter cache"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
📖 We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach. To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a
Changelog
trailer to it. For example:This is my commit's subject line This is the optional commit body. Changelog: added
The value of the
Changelog
trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other.For more information, take a look at the following resources:
https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1564
- https://docs.gitlab.com/ee/api/repositories.html#generate-changelog-data
If you'd like to see the new approach in action, take a look at the commits in the Omnibus repository.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Matija Čupić ( @matteeyah
) (UTC+2, 7 hours ahead of@digitalmoksha
)Mikołaj Wawrzyniak ( @mikolaj_wawrzyniak
) (UTC+2, 7 hours ahead of@digitalmoksha
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #327630 (closed)
mentioned in merge request !60566 (merged)
added sectiondev label
added 805 commits
-
a11dab2f...71dee555 - 804 commits from branch
master
- b0e2a36a - Enable snippets to use reference filter cache
-
a11dab2f...71dee555 - 804 commits from branch
added 1 commit
- a72a73d6 - Enable snippets to use reference filter cache
added 1 commit
- 5de0c4fc - Enable snippets to use reference filter cache
@matteeyah would you mind reviewing? It hooks into our reference caching to remove an N+1
requested review from @matteeyah
added workflowin review label
added 1 commit
- 288355e9 - Enable snippets to use reference filter cache
- Resolved by Matija Čupić
removed review request for @matteeyah
requested review from @matteeyah
- Resolved by Imre Farkas
@ifarkas would you be up for doing the maintainer review?
requested review from @ifarkas and removed review request for @matteeyah
- Resolved by Imre Farkas
- Resolved by Imre Farkas
- Resolved by Imre Farkas
removed review request for @ifarkas
added 651 commits
-
288355e9...a012be9c - 650 commits from branch
master
- 57bb697c - Enable snippets to use reference filter cache
-
288355e9...a012be9c - 650 commits from branch
requested review from @ifarkas
enabled an automatic merge when the pipeline for 6f50c117 succeeds
mentioned in commit 3af9dfe7
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label