Skip to content
Snippets Groups Projects

Enable snippets to use reference filter cache

Merged Brett Walker requested to merge bw-reference-snippet-caching into master
All threads resolved!

What does this MR do?

With the refactored Banzai reference cache, we now enable the SnippetReferenceFilter to take advantage of it.

Related to #327630 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Brett Walker

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matija Čupić approved this merge request

    approved this merge request

  • This looks great to me! I left one minor comment about adding an implementation comment in the code.

  • Matija Čupić removed review request for @matteeyah

    removed review request for @matteeyah

  • Brett Walker requested review from @matteeyah

    requested review from @matteeyah

  • Brett Walker requested review from @ifarkas and removed review request for @matteeyah

    requested review from @ifarkas and removed review request for @matteeyah

  • Imre Farkas
  • Imre Farkas
  • Imre Farkas
  • Imre Farkas removed review request for @ifarkas

    removed review request for @ifarkas

  • Brett Walker added 651 commits

    added 651 commits

    Compare with previous version

  • Brett Walker requested review from @ifarkas

    requested review from @ifarkas

  • Imre Farkas approved this merge request

    approved this merge request

  • Imre Farkas resolved all threads

    resolved all threads

  • Imre Farkas resolved all threads

    resolved all threads

  • Imre Farkas enabled an automatic merge when the pipeline for 6f50c117 succeeds

    enabled an automatic merge when the pipeline for 6f50c117 succeeds

  • merged

  • Imre Farkas mentioned in commit 3af9dfe7

    mentioned in commit 3af9dfe7

  • added workflowstaging label and removed workflowin review label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading