Enable `packages_finder_helper_deploy_token` by default
⛳ Context
packages_finder_helper_deploy_token is a feature flag that enables an improvement an the file API endpoint in the Maven package registry.
The analysis for this improvement is here. Basically, we had a SQL issue when using deploy tokens for the group level API.
The improvement and the feature flag has been introduced by !58497 (merged).
The feature flag has been enabled on gitlab.com on 2021-04-15. It has been running smoothly. The response times of the impacted endpoints have been reduced.
It is now time to enabled this feature flag by default so that self-managed users can receive this improvement.
The feature flag rollout issue is here: #326808 (closed)
Related issue: #327916 (closed)
🔭 What does this MR do?
- Enable
packages_finder_helper_deploy_tokenby default.
No documentation change is needed as this improvement doesn't change any user facing feature.
🖼 Screenshots (strongly suggested)
n / a
⛓ Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team