[Feature flag] Rollout of `packages_finder_helper_deploy_token`
Feature
Improve the SQL queries generated by the package finder helper when the user is a deploy token.
Analysis of the actual problem is here
Owners
- Team: Package
- Most appropriate slack channel to reach out to:
#s_package
- Best individual to reach out to: @10io
- PM: @trizzi
The Rollout Plan
-
Partial Rollout on GitLab.com with beta groups -
Rollout on GitLab.com for a certain period (1 week) -
Percentage Rollout on GitLab.com - XX% If it is possible to perform an incremental rollout, this should be preferred. Proposed increments are: 10%
,50%
,100%
. Proposed minimum time between increments is 15 minutes. -
Rollout Feature for everyone as soon as it's ready
Expectations
What are we expecting to happen?
Head requests on the group level maven file endpoint should have a better latency.
What might happen if this goes wrong?
- HEAD/GET requests on the group level maven file endpoints could fail
- HEAD/GET requests on the group/project level nuget endpoints could fail
What can we monitor to detect problems with this?
Rollout Timeline
Initial Rollout
Preperation Phase
-
Enable on staging ( /chatops run feature set packages_finder_helper_deploy_token true --staging
) -
Test on staging -
[-] Ensure that documentation has been updated (More info)
-
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
by pinging@sre-oncall
- In
#g_delivery
by pinging@release-managers
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com
Partial Rollout Phase
-
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab feature_name true
) -
Verify behaviour (See Beta Groups) and add details with screenshots as a comment on this issue
Global Availability (More Info) (Please Note that Beta,Alpha and General Availability (GA) are handled on a product level and not the feature-flag)
-
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Make the feature flag enabled by default i.e. Change default_enabled
totrue
-
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set feature_name true
) -
Announce on the issue that the flag has been enabled -
Cross post chatops slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel
Cleanup
This is an important phase, that should be either done in the next Milestone or as soon as possible. For the cleanup phase, please follow our documentation on how to clean up the feature flag.
-
Announce on the issue that the flag has been enabled -
Remove :packages_finder_helper_deploy_token
feature flag-
Remove all references to the feature flag from the codebase -
Remove the YAML definitions for the feature from the repository -
Create a Changelog Entry
-
-
Clean up the feature flag from all environments by running this chatops command in #production
channel/chatops run feature delete some_feature
.
Final Step
-
Close this rollout issue for the feature flag after the feature flag is removed from the codebase.
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set packages_finder_helper_deploy_token false