Pipeline Graph: Update graph state selection
What does this MR do?
This MR updates the way the graph is displayed and adds the links toggle. All work is behind the pipelineGraphLayersView
feature flag. The dropdown is replaced with a a segmented selector and, when the layers view is selected, a toggle to hide and show links appears. Both controls also show loading states.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because ff.
-
-
Code review guidelines -
Merge request performance guidelines -
Style guides
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Related to #298973 (closed)
Merge request reports
Activity
changed milestone to %13.11
added frontend label
1 Warning This merge request changed files with disabled eslint rules. Please consider fixing them. 2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 59685 "Pipeline Graph: Update graph state selection"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 59685 "Pipeline Graph: Update graph state selection"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach. To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a
Changelog
trailer to it. For example:This is my commit's subject line This is the optional commit body. Changelog: added
The value of the
Changelog
trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other.For more information, take a look at the following resources:
- gitlab-com/gl-infra/delivery#1564 (closed)
- https://docs.gitlab.com/ee/api/repositories.html#generate-changelog-data
If you'd like to see the new approach in action, take a look at the commits in the Omnibus repository.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/pipelines/components/graph/graph_component_wrapper.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/pipelines/components/graph/graph_component_wrapper.vue'
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Mireya Andres ( @mgandres
) (UTC+8, 6 hours ahead of@sarahghp
)Enrique Alcántara ( @ealcantara
) (UTC-4, 6 hours behind@sarahghp
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖removed candidate13.11 label
changed milestone to %13.12
- Resolved by Andrew Fontaine
@f_caplette More graph party!
requested review from @f_caplette
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Sarah Groff Hennigh-Palermo
- Resolved by Andrew Fontaine
removed review request for @f_caplette
requested review from @f_caplette
requested review from @afontaine
mentioned in issue #328538 (closed)
Looks good to me @sarahghp! Thanks for the great review @f_caplette!
mentioned in commit da5814e1
mentioned in merge request !59913 (merged)
added workflowstaging label and removed workflowplanning breakdown label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !60262 (merged)
added releasedcandidate label
added Category:Pipeline Composition label
added pipeline visualizations label
added pipeline:mr-approved label
added sectionci label and removed sectionops label
removed DEPRECATE_pipeline dag label