Fix Jenkins integration for GitLab FOSS
What does this MR do?
We moved Jenkins integration from EE to Core in 13.7
!37797 (merged) but we
haven't moved the Rails strong parameters jenkins_url
and project_name
causing the validation to fail for GitLab FOSS.
Before | After |
---|---|
![]() |
![]() |
Related to #300121 (closed)
Merge request reports
Activity
changed milestone to %13.11
3 Warnings This MR has a Changelog file outside ee/
, but code changes inee/
. Consider moving the Changelog file intoee/
.This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Max Woolf ( @mwoolf
) (UTC+1, same timezone as@arturoherrero
)Imre Farkas ( @ifarkas
) (UTC+2, 1 hour ahead of@arturoherrero
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #300121 (closed)
All credits for @justin_ho and his amazing investigation #300121 (comment 552596070).
- Resolved by Alex Kalderimis
This looks good to me - feel free to review as a backend maintainer @Andysoiron
assigned to @arturoherrero and @alexkalderimis
mentioned in issue #327875
enabled an automatic merge when the pipeline for da3394ab succeeds
mentioned in commit 5e8f24b7
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in issue gitlab-com/www-gitlab-com#10167 (closed)
added 1 deleted label and removed devopscreate label
added devopsmanage label and removed 1 deleted label