Skip to content

Refactor(CI Minutes): use customer graphql client

What does this MR do?

This MR adds the possibility of using multiple clients in GitLab and uses it to transitions the /buy_minutes-route to use the CustomersDot GraphQL client instead of the service (the service will be removed in this follow-up MR: !59371 (merged)).

Note to reviewer: I tried splitting this into smaller MRs but the possibility of adding multiple clients is inherently tied to using and testing it. If you have better ideas to splitting this further, I am happy to hear from you!

Note that this route is behind a feature flag: Feature.enable(:new_route_ci_minutes_purchase) and currently under development. See the Epic here: &5391 (closed).

There are two MRs in flight after this one:

Screenshots (strongly suggested)

With Data (no change) Without Data (no change)
Screen_Shot_2021-04-14_at_11.50.21 Screen_Shot_2021-04-14_at_10.47.31

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #327922 (closed)

Edited by Michael Lunøe

Merge request reports