Skip to content

Replace invite banner button with modal trigger

Jackie Fraser requested to merge change_invite_banner_button_to_open_modal into master

What does this MR do?

Changes the button on the "Invite your colleagues" banner to open the Invite Members modal, instead of being a link taking them to the Members page.

Related to "Invite your colleagues" banner successful experiment cleanup: https://gitlab.com/gitlab-org/gitlab/-/issues/323106

Related to !59203 (merged)

Related to gitlab-ui!2144 (merged)

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/247208

  • To test:
  1. Create a new group as an admin or owner, with only 1 member (yourself) in that group.
  2. Visit group overview page again, or reload (the banner will not display if the "Group name created" flash message is there)

Screenshots (strongly suggested)

image

open-modal-from-banner

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jackie Fraser

Merge request reports