Add validation directive to DAST Scanner Profile
Related issue - #259684 (closed)
What does this MR do?
DAST Scanner Profile Form
-
Save profile
button should not be disabled (until it's clicked) - Use validation directive for form validations
- Add support for Input Group components in the validation directive
- This MR should ideally fix #327835 too
Screenshots (strongly suggested)
- Submit button
before (disabled submit button) | after |
---|---|
- Validations
before | after |
---|---|
- more validations
boundary check | number validation (reproducible in firefox) |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi