Skip to content

Add validation directive to DAST Scanner Profile

Dheeraj Joshi requested to merge djadmin-scanner-profile-validations into master

Related issue - #259684 (closed)

What does this MR do?

DAST Scanner Profile Form

  • Save profile button should not be disabled (until it's clicked)
  • Use validation directive for form validations
  • Add support for Input Group components in the validation directive
    • This MR should ideally fix #327835 too

Screenshots (strongly suggested)

  • Submit button
before (disabled submit button) after
image image
  • Validations
before after
image image
  • more validations
boundary check number validation (reproducible in firefox)
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi

Merge request reports