Move Service Templates nav link behind a feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

This MR is an iteration towards Service Template deprecation, as we prepare for complete removal of Service Templates in %14.0 (#325196 (closed) and &5672 (closed)). This MR specifically resolves #326962 (closed), by:

• moving the Service Template nav item behind a feature flag (:disable_service_templates), disabled by default

It's worth noting that the actual Service Template page will still exist if the feature flag is enabled (i.e. users can still theoretically navigate to /admin/application_settings/services). Service templates are scheduled for complete removal in %14.1 (#325659 (closed) and #327091 (closed))

Feature flag rollout issue: #327436 (closed)

Screenshots (strongly suggested)

For user with no active service templates

Before	After

Does this MR meet the acceptance criteria?

Conformity

• Does this MR need a changelog?
  • I have included a changelog entry.
  • I have not included a changelog entry because there is no user-facing change.
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %13.11

added Category:Integrations Technical Writing devopscreate feature flag frontend groupecosystem [DEPRECATED] sectiondev typefeature typemaintenance labels

changed title from Draft: Resolve "Move Service Templates UI behind feature flag" to Draft: Move Service Templates UI behind feature flag

changed the description

mentioned in issue #327436 (closed)

added 1 commit

• f3b58441 - Conditionally show Service Templates nav item

Compare with previous version

changed title from Draft: Move Service Templates UI behind feature flag to Draft: Move Service Templates UI behind feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

added backend label

	1 Warning
	featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart. For more information, see: The Handbook page on merge request types. The definition of done documentation.

	3 Messages
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following: bin/changelog -m 59098 "Move Service Templates nav link behind a feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]" If you want to create a changelog entry for GitLab EE, run the following instead: bin/changelog --ee -m 59098 "Move Service Templates nav link behind a feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]" If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
	We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach. To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a Changelog trailer to it. For example: This is my commit's subject line This is the optional commit body. Changelog: added The value of the Changelog trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other. For more information, take a look at the following resources: https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1564 https://docs.gitlab.com/ee/api/repositories.html#generate-changelog-data If you'd like to see the new approach in action, take a look at the commits in the Omnibus repository.
	You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS] (we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
backend	Sarah Yasonik (@syasonik) (UTC-4, 13.5 hours behind @tomquirk)	Etienne Baqué (@ebaque) (UTC+2, 7.5 hours behind @tomquirk)
frontend	Samantha Ming (@sming-gitlab) (UTC-7, 16.5 hours behind @tomquirk)	Jose Ivan Vargas (@jivanvl) (UTC-5, 14.5 hours behind @tomquirk)
test Quality for spec/features/*	Sarah Yasonik (@syasonik) (UTC-4, 13.5 hours behind @tomquirk)	Maintainer review is optional for test Quality for spec/features/*

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 557 commits

• f3b58441...9c35c043 - 556 commits from branch master
• f69469f6 - Conditionally show Service Templates nav item

Compare with previous version

changed the description

removed Technical Writing label

added 1 commit

• 28bc0f37 - Conditionally show Service Templates nav item

Compare with previous version

marked the checklist item I have included a changelog entry. as completed

added 367 commits

• 28bc0f37...d140c45f - 366 commits from branch master
• 582ea5ad - Conditionally show Service Templates nav item

Compare with previous version

added 3 commits

• 582ea5ad...11c635a8 - 2 commits from branch master
• 401583bc - Conditionally show Service Templates nav item

Compare with previous version

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits a277aaf4 and 55d4c263

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.14 MB	3.14 MB	-	0.0 %
mainChunk	1.87 MB	1.87 MB	-	0.0 %

Significant Growth: 1

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.admin.geo.nodes_beta	376.71 KB	384.95 KB	+8.24 KB	2.2 %

---

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Note: We do not have exact data for a277aaf4. So we have used data from: 4329791e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

added 19 commits

• 401583bc...a277aaf4 - 18 commits from branch master
• 55d4c263 - Conditionally show Service Templates nav item

Compare with previous version

marked this merge request as ready

marked the checklist item I have included a changelog entry. as incomplete