Move Service Templates nav link behind a feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This MR is an iteration towards Service Template deprecation, as we prepare for complete removal of Service Templates in %14.0 (#325196 (closed) and &5672 (closed)). This MR specifically resolves #326962 (closed), by:
- moving the Service Template nav item behind a feature flag (
:disable_service_templates), disabled by default
It's worth noting that the actual Service Template page will still exist if the feature flag is enabled (i.e. users can still theoretically navigate to /admin/application_settings/services). Service templates are scheduled for complete removal in %14.1 (#325659 (closed) and #327091 (closed))
Feature flag rollout issue: #327436 (closed)
Screenshots (strongly suggested)
For user with no active service templates
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because there is no user-facing change.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk