Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,125
    • Issues 43,125
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,364
    • Merge requests 1,364
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 has launched! Please visit Breaking changes in 15.0 and 15.0 Removals to see which breaking changes may impact your workflow.

  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !58893

Move required styles for add issueable form

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael Telgkamp requested to merge michael.telgkamp/gitlab:258678-move-add-issuable-styles-to-core into master Apr 08, 2021
  • Overview 8
  • Commits 1
  • Pipelines 5
  • Changes 3

What does this MR do?

This MR moves the required styles for the form used to add linked / related issues from ee to core.

The Feature was introduced in #212329 (closed), but the stylesheet was not moved, yet.

Screenshots (strongly suggested)

Screenshot before change with unstyled form element

see related issues #273558 (closed) and #258678 (closed)

Does this MR meet the acceptance criteria?

Conformity

  • 📋 Does this MR need a changelog?
    • I have included a changelog entry.
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

As the styles are only moved from one scss file in ee to the core file there should not be any impact. The code is already tested for ee version, so the only concern might be the location of the code in the new file.

Related to #258678 (closed), #273558 (closed)

Edited Apr 08, 2021 by Michael Telgkamp
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 258678-move-add-issuable-styles-to-core