Skip to content
Snippets Groups Projects

Pass a Markdown serializer to the Content Editor

Merged Enrique Alcántara requested to merge content-editor-markdown-serializer into master

What does this MR do?

This MR Refactors the Content Editor to decouple Markdown serializing from the Editor itself. The goal is allowing to customize Markdown serialization by configuring a separate serialization object independently from the Content Editor itself.

What are the serialization/deserialization targets?

When deserializing, we want to convert a Markdown string into a ProseMirror document and serialization performs the inverse operation.

Why is this useful?

We have to parse and render Markdown before converting it into a ProseMirror document. The process of parsing and rendering Markdown varies across use cases. That’s why we want to decouple this operation from the Content Editor.

Screenshots (strongly suggested)

This MR does not introduce user-facing changes. The Content Editor is not used by any feature yet.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Enrique Alcántara

Merge request reports

Merged results pipeline #285173309 passed

Merged results pipeline passed for 4b021d9a

Test coverage 63.50% from 3 jobs

Merged by Enrique AlcántaraEnrique Alcántara 4 years ago (Apr 12, 2021 5:59pm UTC)

Loading

Pipeline #285204703 passed

Pipeline passed for e61d74af on master

Test coverage 59.68% from 3 jobs
5 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading